-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the docs for secrets masking + set default masks for AWS #381
Conversation
- # see: https://regex101.com/r/44Ldz7/1 | ||
# looks for `AWS_ACCESS_KEY_ID={string}` | ||
search: (AWS_ACCESS_KEY_ID=)(\S+) | ||
replace: \1******* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the regex rules for AWS locally.
But it's also interesting that you can have unit tests and examples for the regex rule at https://regex101.com/r/snz1j6/1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move that URL to the top of the regex comments, or to the bottom, so that every regex keeps the same style of #comment / replace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be consistent, I would use
# comment
replace
# comment
replace
We could add a bigger headder on top of the replacements with the URL and some info if needed. Or at the bottom.
- # see: https://regex101.com/r/44Ldz7/1 | ||
# looks for `AWS_ACCESS_KEY_ID={string}` | ||
search: (AWS_ACCESS_KEY_ID=)(\S+) | ||
replace: \1******* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would move that URL to the top of the regex comments, or to the bottom, so that every regex keeps the same style of #comment / replace
Closes #374
Also adds AWS secret ENVs to the default config, so it's secure by default.