Exit with the error on unsupported bitops schema data type in fail_fast mode

[PhillypHenning]

Description

Small update to the exit logic for fail fast usage, this is to properly support our Github Action usage

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally

Logs

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation

[arm4b]

The PR title will need better detail as we're generating Release notes based on those.

Exit with the error on unsupported data type in bitops schema.

as I have zero context, ^^ is that accurate?

Is there perhaps an example or logs that may highlight the bug we're fixing in this PR?

[mickmcgrath13]

This PR should probably fix a bug with exiting in run_cmd.

I’m not convinced the exception is being raised..
Might need to use pipe.returncode after pipe.communicate

more context:
pipeline is using bitops 2.2.1:
https://github.com/bitovi/devops-training-ec2-gha-example/actions/runs/3639474356/jobs/6143060556#step:2:240
Pipeline should have failed here (before script):
https://github.com/bitovi/devops-training-ec2-gha-example/actions/runs/3639474356/jobs/6143060556#step:2:760
before script calls run_cmd:

bitops/scripts/plugins/utilities.py

Line 342 in 5b0fec0

result = run_cmd(["bash", plugin_before_hook_script_path])

run_cmd check BITOPS_fast_fail_mode:

bitops/scripts/plugins/utilities.py

Line 374 in 5b0fec0

if BITOPS_fast_fail_mode:

[mickmcgrath13]

need this:

process.communicate()
process_return_code = process.returncode
if process_return_code = 0:
  print("yay")
else:
  logger.error("not yay")
  sys.exit(101)

[arm4b]

@mickmcgrath13 That bug fix is in the #373 PR.