Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins doc with the correct _SKIP_DEPLOY ENV vars #354

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

PhillypHenning
Copy link
Contributor

Description

Updated to support the skip_deployment configuration option that was added to all major supported plugins.

Type of change

  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@PhillypHenning PhillypHenning changed the title Updating terraform doc Updating plugin doc to support skip_deploy configuration change Nov 10, 2022
@PhillypHenning PhillypHenning self-assigned this Nov 10, 2022
@PhillypHenning PhillypHenning added documentation 📗 Improvements or additions to documentation plugins labels Nov 10, 2022
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross-linking with

Based on what we've seen there are lots of documentation misses and outdated things here and there.

It's nice to see the _SKIP_DEPLOY consistency across the board and all the places: plugins + Readmes + docs 👍

@arm4b arm4b added this to the v2.2.0 milestone Nov 10, 2022
@arm4b arm4b changed the title Updating plugin doc to support skip_deploy configuration change Update plugin doc with the correct _SKIP_DEPLOY ENV vars Nov 14, 2022
@arm4b arm4b changed the title Update plugin doc with the correct _SKIP_DEPLOY ENV vars Update plugins doc with the correct _SKIP_DEPLOY ENV vars Nov 14, 2022
@arm4b arm4b merged commit bec715a into main Nov 14, 2022
@arm4b arm4b deleted the plugin-doc-update branch November 14, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📗 Improvements or additions to documentation plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants