-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local plugin install #349
Merged
Merged
Local plugin install #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
reviewed
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked quickly, nice stuff! 💯
Will try the whole new experience end-to-end later.
PhillypHenning
requested changes
Nov 9, 2022
arm4b
requested changes
Nov 14, 2022
arm4b
reviewed
Nov 14, 2022
fix plugin source path check to handle relative dir Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
fix plurality and specify remote source type Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
use dev tag for local dev Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
remove pythonunbuffered flag from docker run example Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
arm4b
reviewed
Dec 19, 2022
arm4b
reviewed
Dec 19, 2022
arm4b
reviewed
Dec 19, 2022
PhillypHenning
approved these changes
Dec 19, 2022
arm4b
reviewed
Dec 19, 2022
arm4b
reviewed
Dec 19, 2022
arm4b
reviewed
Dec 19, 2022
fix casing in schema Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
fix path to installed plugins in local-plugin-create Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
I thought we did this one already.. :) Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
update ref to plugin installation path Co-authored-by: Eugen C. <1533818+armab@users.noreply.github.com>
arm4b
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces the functionality to use
file://
for BitOps configs when building your own BitOps image to use locally-developed plugins.It works by providing a
plugins
directory as a sibling directory to theDockerfile
(required for Docker build accessibility). When aplugins/
directory exists, the DockerONBUILD
directives will copy the contents into the container at/opt/bitops-local-plugins
. From there, the BitOps-levelbitops.config.yaml
can reference the plugin like:Closes #308
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
See the docs included in the PR. Tested with both local (
file://
) plugin references as well as URL based.Checklist: