Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inexistent ENV vars from the docs #279

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

arm4b
Copy link
Member

@arm4b arm4b commented Aug 17, 2022

The documented env vars BITOPS_DEFAULT_REPLACE and SKIP_IF_NO_ENVIRONMENT_CHANGES are not implemented. Please let me know if they're coded anywhere as I couldn't find any implementation in the history and implementation.

Removing from the docs to avoid any confusion.

The described env var functionality is not implemented anywhere
The described SKIP_IF_NO_ENVIRONMENT_CHANGES functionality is not implemented anywhere
@arm4b arm4b added bug 🪲 Something isn't working documentation 📗 Improvements or additions to documentation labels Aug 17, 2022
@arm4b arm4b merged commit b4e70b4 into main Aug 17, 2022
@arm4b arm4b deleted the doc/remove-unused-vars branch August 17, 2022 19:53
@mickmcgrath13
Copy link
Contributor

SKIP_IF_NO_ENVIRONMENT_CHANGES was implemented in V1 to check the git log on an attempted run. if no files in the git log matched the ENVIRONMENT env var, bitops would exit the deployment.
here's the v1 code:
https://github.com/bitovi/bitops/blob/v1.0.18/scripts/deploy.sh#L80-L95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working documentation 📗 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants