Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a fooling mistake #275

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Fixing a fooling mistake #275

merged 4 commits into from
Aug 11, 2022

Conversation

PhillypHenning
Copy link
Contributor

@PhillypHenning PhillypHenning added the bug 🪲 Something isn't working label Aug 11, 2022
PhillypHenning and others added 2 commits August 11, 2022 10:28
* Initial Documentation update DevOps2-90 (#264)

* Initial Documentation update DevOps2-90

* Created Getting Started page, various updates

* Minor updates

* Fix 'base' image docker tagging (#265)

* Fix 'base' image docker tagging

* Add message coloring for the docker publish script

* Add more documentation for the docker publish script

Co-authored-by: Chris Capell <57496718+ccapell@users.noreply.github.com>
Co-authored-by: Eugen C <1533818+armab@users.noreply.github.com>
Copy link
Contributor

@ccapell ccapell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in PR# 272 may cause merge issues with your doc changes.

@PhillypHenning
Copy link
Contributor Author

I'll wait until you merge those in, I will then remerge main -> this branch

That should ensure everything is kept

@ccapell ccapell added the documentation 📗 Improvements or additions to documentation label Aug 11, 2022
@PhillypHenning PhillypHenning merged commit 2bca05e into main Aug 11, 2022
@PhillypHenning PhillypHenning deleted the default-folder-fix branch August 11, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Something isn't working documentation 📗 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants