Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating splash about #273

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Updating splash about #273

merged 3 commits into from
Aug 11, 2022

Conversation

PhillypHenning
Copy link
Contributor

@PhillypHenning PhillypHenning commented Aug 10, 2022 •
edited
Loading

Quick update to splash text

arm4b
arm4b reviewed Aug 10, 2022
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
arm4b
arm4b approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much more clear to me 👍

@arm4b
Copy link
Member

arm4b commented Aug 10, 2022

@mickmcgrath13 @ccapell WDYT? ^^

We went to the docs and it looked confusing:
image
Now I see that Consistently Deploy is a separated <h1>, though the new version by @PhillypHenning looks like a better description.

ccapell
ccapell approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@ccapell ccapell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@armab, you won't see the changes in the documentation site until they are approved and pushed.

mickmcgrath13
mickmcgrath13 reviewed Aug 10, 2022
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
@arm4b arm4b added documentation 📗 Improvements or additions to documentation enhancement ✨ New feature or request labels Aug 10, 2022
arm4b
arm4b reviewed Aug 11, 2022
View reviewed changes
docs/index.md Show resolved Hide resolved
@arm4b
Copy link
Member

arm4b commented Aug 11, 2022 •
edited
Loading

Nice! Looks like we're ready to get this merged @PhillypHenning with all the consensus 👍

@PhillypHenning PhillypHenning merged commit 2dac857 into main Aug 11, 2022
@PhillypHenning PhillypHenning deleted the index-update branch August 11, 2022 14:38
@arm4b arm4b mentioned this pull request Aug 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

@mickmcgrath13 mickmcgrath13 mickmcgrath13 approved these changes

@ccapell ccapell ccapell approved these changes

Assignees
No one assigned
Labels
documentation 📗 Improvements or additions to documentation enhancement ✨ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PhillypHenning @arm4b @mickmcgrath13 @ccapell