-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add logic to handle aws token for sso accounts #163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmcgrath13
requested review from
ConnorGraham,
dylan-bitovi and
PhillypHenning
April 6, 2022 15:08
👍 Great description of work. Thanks for keeping it clean. 👍 Code looks good. I can't see any potential problems arising |
ConnorGraham
reviewed
Apr 6, 2022
ConnorGraham
approved these changes
Apr 6, 2022
dylan-bitovi
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 LGTM!
PhillypHenning
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AWS SSO credentials require
AWS_SESSION_TOKEN
to work properly. This PR adds the env var to the/root/.aws/credentials
file if the env var exists.(note: I would expect the env vars alone to work, but I tested that, and they do not)
Fixes #162
Fixes #141
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
exit 0
before all the other code can runLogs
bitops command:
aws command
without change
With change
Test Configuration:
Checklist: