-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding skip-deploy bitops configuration option #13
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5e9c2a8
Updating README skip-deploy option
PhillypHenning a763179
Replacing SKIP_DEPLOY_HELM option with HELM_SKIP_DEPLOY and adding "t…
PhillypHenning f093aec
Updating default value to `""`
PhillypHenning 3c3fb7f
Removing SKIP_DEPLOY check (favoring later check)
PhillypHenning c05e632
removing sanity check
PhillypHenning 6d2488c
Removing required attribute
PhillypHenning File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -127,10 +127,10 @@ simulate an install | |||||||||||
------------------- | ||||||||||||
### skip-deploy | ||||||||||||
* **BitOps Property:** `skip-deploy` | ||||||||||||
* **Environment Variable:** `SKIP_DEPLOY` | ||||||||||||
* **default:** `""` | ||||||||||||
|
||||||||||||
will skip helm execution | ||||||||||||
* **Environment Variable:** `HELM_SKIP_DEPLOY` | ||||||||||||
* **default:** `none` | ||||||||||||
* **Required:** `false` | ||||||||||||
* **Description:** If set to true, regardless of the stack-action, deployment actions will be skipped. | ||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like it's not helm/scripts/helm_handle_chart.sh Lines 18 to 22 in b77f296
Sounds like a bug? I see we use |
||||||||||||
|
||||||||||||
------------------- | ||||||||||||
### release-name | ||||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see only one config setting
namespace
in this README mentions the required.Do we really need to list the
required
property? What's the convention we'd like to go with?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other documentation has the "required" flag. Defaults to false.
How did you want to handle this?