[bitnami/etcd] Stop logging root password #63437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thank you so much for the PR! Could you fix the DCO issue? |
Signed-off-by: jb-abbadie <jb-abbadie@users.noreply.github.com>
jb-abbadie
force-pushed
the
stop_logging_root_password
branch
from
2d5abee
to
c11868a
Compare
|
DCO issue is fixed |
carrodher
added
verify
juan131
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Stop logging root password for etcd
Benefits
This will avoid logging sensitive information in the stdout of the pod
Possible drawbacks
N/A
Applicable issues
bitnami/charts#23910
Additional information