Update openldap libopenldap.sh #53960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during openldap init, do the tls configuration before adding custom ldif Signed-off-by: jpgouin <jp-gouin@hotmail.fr>
carrodher
added
verify
|
@FraPazGal why this change do not apply to debian-12, moreover, are there any more pr have been lost. @jp-gouin |
|
it seem to be reverted by stupid bot, #55570, and gratifying thing is no other pr have was lost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
During Openldap init, this change does the TLS configuration before adding custom LDIFs.
Benefits
Using this helm chart, this change fixes a replication issue.
This chart allows users to spin up Openldap in K8S in a high availability mode. In a multi-node scenario, the first one starts without issue, other ones are in a race condition when setting up the tree (
ldap_create_tree) and ldifldap_add_custom_ldifs) due to the replication. This is an expected behaviour and once the replication kicks in all nodes are running.By doing the TLS initialisation at the end of
ldap_initialize()the TLS is not properly configured when Openldap restart.Applicable issues