Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/containers] Run license check on modified files #17542 #40523

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

fmulero
Copy link
Collaborator

@fmulero fmulero commented Jul 10, 2023

Description of the change

Run license header check only on modified files. Please note that current configuration only checks Dockerfiles

Benefits

Users won't be warned about errors in license header coming from main branch.

Possible drawbacks

None identifed

Applicable issues

Additional information

Several tests performed in a forked repository:

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Fran Mulero <fmulero@vmware.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero fmulero requested a review from rloporp July 10, 2023 16:37
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jul 10, 2023
@fmulero fmulero merged commit 7042b36 into bitnami:main Jul 11, 2023
11 checks passed
@fmulero fmulero deleted the feature/check-license-changed-files branch July 11, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants