Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/minio] fix data_dir not effective in minio snsd mode #39731

Merged
merged 2 commits into from
Jul 21, 2023
Merged

[bitnami/minio] fix data_dir not effective in minio snsd mode #39731

merged 2 commits into from
Jul 21, 2023

Conversation

haojingcn
Copy link
Contributor

Description of the change

Benefits

Possible drawbacks

Applicable issues

Additional information

[bitnami/minio] fix bitnami#39426
f7d567f 
Signed-off-by: mahaojing <mahaojing@corp.netease.com>
@github-actions github-actions bot added the minio label Jul 3, 2023
@github-actions github-actions bot added the triage Triage is needed label Jul 3, 2023
@haojingcn haojingcn changed the title [bitnami/minio] fix #39426 [bitnami/minio] fix data_dir not effective in minio snsd mode Jul 3, 2023
@javsalgar javsalgar added the verify Execute verification workflow for these changes label Jul 3, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Jul 3, 2023
@bitnami-bot bitnami-bot removed the request for review from javsalgar July 3, 2023 08:53
@bitnami-bot bitnami-bot requested a review from corico44 July 3, 2023 08:53
@corico44
Copy link
Contributor

Hello @haojingcn,

The issue related to this PR says the following:
use /data-minus, instead of /data
Why do you consider that the change to fix it that you propose is appropriate?

@haojingcn
Copy link
Contributor Author

Hello @haojingcn,

The issue related to this PR says the following: use /data-minus, instead of /data Why do you consider that the change to fix it that you propose is appropriate?

MINIO_DATA_DIR Is HardCode, nomatter how it change, it always be the /data(see that picture). So If you set MINIO_DATA_DIR as /data-minus, MINIO use /data as it store directory.

corico44
corico44 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@corico44 corico44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corico44 corico44 merged commit 17b5440 into bitnami:main Jul 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corico44 corico44 corico44 approved these changes

Assignees

@corico44 corico44

Labels
minio solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/minio] SNSD situation: change MINIO_DATA_DIR not affected
4 participants
@haojingcn @corico44 @javsalgar @fmulero