Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/fix redis rdb policy logic #37523

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Chore/fix redis rdb policy logic #37523

merged 6 commits into from
Aug 8, 2023

Conversation

dogzzdogzz
Copy link
Contributor

@github-actions github-actions bot added the triage Triage is needed label Jun 14, 2023
@dogzzdogzz
chore/fix-REDIS_RDB_POLICY-logic
db9b6c4 
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
@dogzzdogzz
add for 7,0
067c6d6 
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
@dogzzdogzz
add disabled option
cd05ce7 
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
@dogzzdogzz dogzzdogzz force-pushed the chore/fix-REDIS_RDB_POLICY-logic branch from 92a154c to cd05ce7 Compare June 14, 2023 09:57
@carrodher carrodher added the verify Execute verification workflow for these changes label Jun 14, 2023
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Jun 14, 2023
@bitnami-bot bitnami-bot removed the request for review from carrodher June 14, 2023 11:46
@dogzzdogzz dogzzdogzz requested a review from corico44 June 29, 2023 04:10
@corico44
Copy link
Contributor

Hello @dogzzdogzz. Thanks for creating this PR. Please, note it is needed to sign the commits. Your signature certifies that you wrote the patch or otherwise have the right to contribute the material. You can find more info about this topic, in the “Sign your work” section from the contributing guidelines.

@dogzzdogzz dogzzdogzz force-pushed the chore/fix-REDIS_RDB_POLICY-logic branch from 65dfde1 to e883887 Compare July 3, 2023 02:17
@dogzzdogzz
add space
11451b3 
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
@dogzzdogzz dogzzdogzz force-pushed the chore/fix-REDIS_RDB_POLICY-logic branch from e883887 to 11451b3 Compare July 3, 2023 02:19
@dogzzdogzz
add space
6309286 
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
@dogzzdogzz
Copy link
Contributor Author

@corico44 Thanks for the reminding, the commits have been signed off

@dogzzdogzz
Add env var REDIS_RDB_POLICY_DISABLED
162d316 
Signed-off-by: Tony Lee <dogzzdogzz@gmail.com>
corico44
corico44 approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@corico44 corico44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Aug 3, 2023
@dogzzdogzz
Copy link
Contributor Author

/remove-stale

@github-actions github-actions bot removed the stale 15 days without activity label Aug 4, 2023
@corico44 corico44 merged commit eb73260 into bitnami:main Aug 8, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corico44 corico44 corico44 approved these changes

@migruiz4 migruiz4 Awaiting requested review from migruiz4

Assignees

@corico44 corico44

Labels
redis-cluster solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/redis-cluster] The save config is overridden due to wrong logic in libredis.sh
4 participants
@dogzzdogzz @corico44 @migruiz4 @carrodher