-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/mongodb] Create replicaset keyFile before mongo starts #32665
Conversation
Signed-off-by: Ryan Riley <ryan.riley@cyber.gc.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes need to be tested and reviewed internally, in any case could you fix the indentation?
Signed-off-by: Ryan Riley <ryan.riley@cyber.gc.ca>
@mdhont done |
Hello, I have been working with this container recently and have applied a work around which also creates and configures the keyfile before I noticed that you have moved (In my scenario i am passing |
Signed-off-by: Ryan Riley <ryan.riley@cyber.gc.ca>
Good point @dtrts. I've made the suggested change, and left the listen-all configuration where it was. |
Bump |
1 similar comment
Bump |
@mdhont is the review underway or scheduled? |
The solution is failing in our internal tests, and it needs some further investigation to find the cause. |
@mdhont thank you for the update. |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
@rrileyca, the license-header-linter job is failing, which is checking if some files contain a needed header. As this has recently been added could you sync your fork and do a rebase on the main branch? |
@mdhont Done! Thanks for reviewing. |
Description of the change
This change creates the MongoDB Replicaset keyFile before
mongod
starts.Benefits
This is needed because if an externally mounted file references the default keyFile that is made at path
/opt/bitnami/mongodb/conf/keyfile
, MongoDB will fail to start due to the non-existant file.Possible drawbacks
To my understanding, none.
Applicable issues