Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use string for encryptedData #203

Closed
wants to merge 1 commit into from
Closed

use string for encryptedData #203

wants to merge 1 commit into from

Conversation

mkmik
Copy link
Collaborator

@mkmik mkmik commented Jul 25, 2019

Closes #201

@mkmik mkmik requested a review from atomatt July 25, 2019 16:24
@mkmik
Copy link
Collaborator Author

mkmik commented Jul 25, 2019

@catac do you have the BW to ensure the tests pass?

@mkmik mkmik mentioned this pull request Jul 26, 2019
Merged
@mkmik
Copy link
Collaborator Author

mkmik commented Jul 26, 2019

thanks @catac, I built on top of your fix in #206

@mkmik mkmik closed this Jul 26, 2019
bors bot added a commit that referenced this pull request Jul 26, 2019
@bors @catac
Merge #206
42b5c46 
206: Fix endless loop when a single sealedsecret has a base64 decode error r=mkmik a=mkmik

Closes #201 

Supersedes #203, adding fixes to tests and addressing review comments (created new PR because I cannot add commits in that fork)

Co-authored-by: catac <catalin.cirstoiu@gmail.com>
Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomatt atomatt atomatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Endless loop in controller on invalid base64 encrypted data
3 participants
@mkmik @atomatt @catac