Add keyboard support to the new SettingsPanel design
#684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* handles keyboard interactivity implementation for SettingsPanels
…ingsPanelSelectOption
* disables bubbling up to parent elements if they are also focusable
stonko1994
commented
Jan 17, 2025
| @if $inset == false { | ||
| box-shadow: $focus-element-box-shadow; | ||
| } @else { | ||
| box-shadow: inset $focus-element-box-shadow; |
There was a problem hiding this comment.
The box shadow has to be inset for settings panel items as otherwise it is not visible (they are at the edge of the settings panel and it has the overflow hidden)
stonko1994
commented
Jan 17, 2025
| @@ -129,6 +129,10 @@ export class Container<Config extends ContainerConfig> extends Component<Config> | |||
| 'aria-label': i18n.performLocalization(this.config.ariaLabel), | |||
| }, this); | |||
|
|
|||
| if (typeof this.config.tabIndex === 'number') { | |||
There was a problem hiding this comment.
The ComponentConfig already has the tabIndex property but it's not consistently applied when creating the dom elements.
stonko1994
commented
Jan 17, 2025
Comment on lines
+80
to
+82
| buttonElement.on('focusin focusout', (e) => { | ||
| e.stopPropagation(); | ||
| }); |
There was a problem hiding this comment.
This is needed to stop bubbling of the focusin event to parents. This is a problem in the new settings panel where the subtitle settings button is inside a focusable settings panel item. Without that the focusin fires on both elements which is undesired.
…eature/add-keyboard-support-to-the-new-settings-panel
bitmovin-kenny
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
SettingsPaneldesign doesn't support keyboard interactions yet. In the old layout this was handled by the browser as we usedSelectBoxes. Since we switched to a custom element in the new layout we need to add the keyboard support manually.This PR introduces a new
InteractiveSubtitleSettingsPanelItem, adding key listeners that trigger the existing click event. The new type is used as super type for theDynamicSettingsPanelItemand theSettingsPanelSelectOption.