This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Strip JWT base64 padding before parsing. #560 #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, that's a mistake on my part. cc @jehiah who can take a look as I am not a maintainer anymore. If we don't end up reverting the commit, it would be good to include a test case for this as well in |
|
... now that I look closer, this is sort of equivalent reverting #421, but a bit simpler IMHO, so I change my mind and think we should merge this :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provider used to allow padding, until it was switched to the builtin RawURLEncoding. This PR fixes the regression by accepting padding again via throwing the padding away.
Google doesn't include padding, but other OAuth2 servers may, and this provider is the default when using a custom provider.