Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

gracefully report un-parsed upstream URL #431

Merged
merged 2 commits into from
Aug 29, 2017

Conversation

ploxiln
Copy link
Contributor

@ploxiln ploxiln commented Aug 5, 2017

fixes #430

Current master branch:

$ ./oauth2_proxy --upstream=127.0.0.1:8080
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x40 pc=0x13b8d2f]

goroutine 1 [running]:
main.(*Options).Validate(0xc4200f8000, 0xc4200f8000, 0xc420012480)
	/Users/pierce/go/src/github.com/bitly/oauth2_proxy/options.go:149 +0x30f
main.main()
	/Users/pierce/go/src/github.com/bitly/oauth2_proxy/main.go:101 +0x1303

This branch:

$ ./oauth2_proxy --upstream=127.0.0.1:8080
2017/08/05 13:17:42 main.go:103: Invalid configuration:
  missing setting: cookie-secret
  missing setting: client-id
  missing setting: client-secret
  missing setting for email validation: email-domain or authenticated-emails-file required.
      use email-domain=* to authorize all email addresses
  error parsing upstream: parse 127.0.0.1:8080: first path segment in URL cannot contain colon

cc @tpherndon

Copy link
Member

@jehiah jehiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 much more useful!

@jehiah jehiah merged commit 23cef89 into bitly:master Aug 29, 2017
@jehiah jehiah added the docs label Aug 29, 2017
@jehiah jehiah added this to the v2.3 milestone Oct 23, 2017
@ploxiln ploxiln deleted the nil_upstream_url branch December 19, 2017 02:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

"Fail!" with Google provider
2 participants