-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
oauthproxy.go
Outdated
p.OAuthStart(rw, req) | ||
} else { | ||
p.SignInPage(rw, req, 200) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what #284 is referring to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better for this to be in a separate PR, not mixed in with this one.
Could still use some tests. Lemme know if you have any specific rules about contributing and I'm happy to comply. |
b9ff581
to
81661a5
Compare
This is very much needed! |
See issue #428 |
@abraithwaite Validation does not work. Specifically request to oauth2_proxy/providers/facebook.go Lines 78 to 80 in a9c55bd
|
Thanks. I'll try and look at it when I have time, otherwise if someone else beats me to it please close this PR! |
eba4f37
to
81661a5
Compare
Commenting here to show support for this and follow updates |
Since I can't edit this PR directly, opened #528. |
Neat! Been waiting to close this. Thanks! |
No description provided.