-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert Line Feed for each paragraph #107
Conversation
thanks for your contribution, sounds good. |
@emmemme could you please add the new parameter to https://github.com/bithost-gmbh/pdfviewhelpers/blob/master/Documentation/ViewHelpers/TextViewHelper/Index.rst ? |
Thanks for your code! M |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @emmemme for your contribution! That looks like a very useful setting to be added!
There are however a few things that still need to be done until this could be released:
- Please rename the setting to
paragraphLineFeed
as we try to avoid abbreviations - The property needs to be added to
AbstractTextViewHelper::$mergeProperties
in order to support the settings inheritance - It should be added to
setup.txt
with default value0
forgeneralText
and empty fortext
,headline
andlist
(similar to other text properties) - It should also be added to
Documentation/ConfigurationReference/TypoScriptReference/Index.rst
the same way other text properties such astrim
are added - The attribute should also be added to the template in
Documentation/ViewHelpers/HeadlineViewHelper/Index.rst
andDocumentation/ViewHelpers/ListViewHelper/Index.rst
- It would be nice if you could squash all the commits into one single commit using
git reset --soft HEAD~3
andgit commit
(replace3
with the number of commits you want to squash): https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git - In addition the XML schema needs to be recompiled (I will take care of this)
If you have time to address these todos that would be awesome! Else I will try to take care of this when I work on some of the other issues in the upcoming days or weeks.
I'll do it during the next weekend... no problem. |
@emmemme Looks perfect to me! 😍 Thank you very much for your contribution! If you like the project, please consider giving it a star :) |
Insert LF to each paragraph and disable justification in last line of the paragraph where align is "justify".
Before:
After: