Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert Line Feed for each paragraph #107

Merged
merged 2 commits into from
Apr 6, 2019

Conversation

emmemme
Copy link

@emmemme emmemme commented Apr 4, 2019

Insert LF to each paragraph and disable justification in last line of the paragraph where align is "justify".

Before:
paragraphLF-before

After:
paragraphLF-after

@macjohnny macjohnny requested a review from maechler April 4, 2019 14:36
@macjohnny
Copy link
Member

thanks for your contribution, sounds good.

@macjohnny
Copy link
Member

@emmemme
Copy link
Author

emmemme commented Apr 4, 2019

Thanks for your code! M

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maechler maechler changed the base branch from master to develop April 4, 2019 16:17
Copy link
Member

@maechler maechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emmemme for your contribution! That looks like a very useful setting to be added!

There are however a few things that still need to be done until this could be released:

  • Please rename the setting to paragraphLineFeed as we try to avoid abbreviations
  • The property needs to be added to AbstractTextViewHelper::$mergeProperties in order to support the settings inheritance
  • It should be added to setup.txt with default value 0 for generalText and empty for text, headline and list (similar to other text properties)
  • It should also be added to Documentation/ConfigurationReference/TypoScriptReference/Index.rst the same way other text properties such as trim are added
  • The attribute should also be added to the template in Documentation/ViewHelpers/HeadlineViewHelper/Index.rst and Documentation/ViewHelpers/ListViewHelper/Index.rst
  • It would be nice if you could squash all the commits into one single commit using git reset --soft HEAD~3 and git commit (replace 3 with the number of commits you want to squash): https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git
  • In addition the XML schema needs to be recompiled (I will take care of this)

If you have time to address these todos that would be awesome! Else I will try to take care of this when I work on some of the other issues in the upcoming days or weeks.

@emmemme
Copy link
Author

emmemme commented Apr 4, 2019

I'll do it during the next weekend... no problem.

@maechler maechler merged commit d6fe149 into bithost-gmbh:develop Apr 6, 2019
@maechler
Copy link
Member

maechler commented Apr 6, 2019

@emmemme Looks perfect to me! 😍 Thank you very much for your contribution!

If you like the project, please consider giving it a star :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants