feat: move custom variables to $(custom:...) with backward compatibility #2868
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responds, in part to #2812 by moving custom variables from
$(internal:custom_...)
to$(custom:...)
. Checks are added to maintain backwards compatibility with legacy names.If we want to move forward I'll get the rest of the action items executed.
My main reason for attempting this is that with the addition of
$(this:...)
, it seems logical to me to make this change. The fact thatcustom
isn't a reserved word in v2.x is concerning, but I think is quite the edge case for someone to completely rename an instance tocustom
. But that can be investigated for upgrade mitigation ... though scrubbing the variables might become difficult.TODO:
custom
instance name mitigation in v2-v3 upgrade