[BUG] Reset Configuration - Surfaces does not clear (all) surfaces from the list

[LikeThisReview]

Is this a bug in companion itself or a module?

• I believe this to be a bug in companion

Is there an existing issue for this?

• I have searched the existing issues

Describe the bug

After Reset Configuration with all Reset Options checked there were still a number of Surfaces listed on the surface page, including a connected Stream Deck (OK), Emulators and Stream Decks not attached to the computer

Steps To Reproduce

Reset Configuration with all Reset Options checked

Expected Behavior

No surfaces in the list, or only the surfaces actually connected to the computer

Environment (please complete the following information)

- OS: Windows 11
- Browser: Edge
- Companion Version: v3.4.0

Additional context

No response

[jwetzell]

As it works right now I see that the following parts of surfaces are "reset".

• all settings (grid offset, row/column count for emulators, rotation, etc.)
• "Offline" surfaces are removed (this doesn't match what you are seeing so may need more looking at)
• emulators are added back with settings reset (like you said this isn't what I would expect either)
• actively connected surfaces are added back with settings reset

Removing the emulators should be fairly easy (I've got it working locally) if that is what should be happening I can propose the small change I made to get that working.

[LikeThisReview]

Thanks! I do not know the way it should work but my expectations as a user is that when I do a full configuration reset that I get an initial setup as if I installed Companion the first time. Keeping active surfaces makes sense to me.

…

On Sat, 14 Sep 2024 at 15:39, Joel Wetzell ***@***.***> wrote: As it works right now I see that the following parts of surfaces are "reset". - all settings (grid offset, row/column count for emulators, rotation, etc.) - "Offline" surfaces are removed (this doesn't match what you are seeing so may need more looking at) - emulators are added back with settings reset (like you said this isn't what I would expect either) - actively connected surfaces are added back with settings reset Removing the emulators should be fairly easy (I've got it working locally) if that is what should be happening I can propose the small change I made to get that working. — Reply to this email directly, view it on GitHub <#3034 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A25NECF7F3MODFNI5O2INU3ZWQ4C3AVCNFSM6AAAAABOGW26F2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJQHE4TKMZTGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Julusian]

good spot, this is fixed now.
It is intentional that any connected streamdecks will remain, and that matches how companion would behave if they were connected before launching it for the first time.

This also made me realise that it wouldn't clear any tcp connected streamdeck studios, which should be reset too.

[LikeThisReview]

👍😀

…

On Mon, 16 Sep 2024 at 13:16, Julian Waller ***@***.***> wrote: good spot, this is fixed now. It is intentional that any connected streamdecks will remain, and that matches how companion would behave if they were connected before launching it for the first time. This also made me realise that it wouldn't clear any tcp connected streamdeck studios, which should be reset too. — Reply to this email directly, view it on GitHub <#3034 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A25NECBPJL5VZBCDL6UTAU3ZW24XPAVCNFSM6AAAAABOGW26F2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJSGYZTEMZVGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>