Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move electron packages from devDependencies to dependencies #40

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

hammady
Copy link
Contributor

@hammady hammady commented Mar 10, 2022

This closes #39.
Without this change, starting the electron app would fail because the 3 moved packages are not installed as they are only development dependencies.

@Julusian Julusian changed the title Move electron packages from devDependencies to dependencies fix: Move electron packages from devDependencies to dependencies Mar 10, 2022
@Julusian Julusian merged commit 52e3ba6 into bitfocus:master Mar 10, 2022
@Julusian
Copy link
Member

Oops, I even had this staged locally but forgot to commit and push it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build and run electron app on Apple M1
2 participants