Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalAddressBook: rename account to addressbookAccount #1095

Conversation

ArnyminerZ
Copy link
Member

Purpose

Rename all occurences of account to addressBookAccount so that address book accounts won't be confused with DAVx5 accounts that easy.

Short description

Upgraded vcard4android to the latest version available (also upgrades compileSdk to 35).

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
Signed-off-by: Arnau Mora Gras <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the refactoring Internal improvement of existing functions label Oct 22, 2024
@ArnyminerZ ArnyminerZ self-assigned this Oct 22, 2024
@ArnyminerZ ArnyminerZ mentioned this pull request Oct 22, 2024
4 tasks
@ArnyminerZ ArnyminerZ marked this pull request as ready for review October 22, 2024 09:57
@ArnyminerZ ArnyminerZ requested a review from rfc2822 October 22, 2024 09:58
@ArnyminerZ
Copy link
Member Author

Okay, my bad @rfc2822, now it should be alright

Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully it will further reduce confusion

@rfc2822 rfc2822 changed the title Upgrade vcard4android LocalAddressBook: rename account to addressbookAccount Oct 22, 2024
@rfc2822 rfc2822 force-pushed the 1086-localaddressbook-rename-account-to-addressbookaccount-new branch from 16d2698 to 5c9b913 Compare October 22, 2024 11:59
@rfc2822 rfc2822 merged commit 3d198f5 into main-ose Oct 22, 2024
8 checks passed
@rfc2822 rfc2822 deleted the 1086-localaddressbook-rename-account-to-addressbookaccount-new branch October 22, 2024 12:07
@rfc2822 rfc2822 linked an issue Oct 30, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Internal improvement of existing functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalAddressBook: rename account to addressBookAccount
2 participants