-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postgres Tests #64
Postgres Tests #64
Conversation
README.md
Outdated
|
||
### Tests and Postgres | ||
|
||
To ```stack test``` with Postgresql you'll need to set the Postgres flag to true in esqueleto.cabal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's another way to do this: stack test --flag esqueleto:postgresql
README.md
Outdated
Default: False | ||
``` | ||
|
||
If you don't have Postgres install it. Using apt-get it's just: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add instructions for other users maybe? I'm thinking homebrew
or else link to postgres site itself.
README.md
Outdated
postgres=# \password esqutest | ||
``` | ||
|
||
Now ```stack test``` should envoke and pass all the Postgres tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeat from comment above stack test --flag esqueleto:postgresql
Added homebrew instructions and command line flag instruction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :) @bitemyapp You happy with this?
Merged 👍 |
github: FintanH and I thought some instructions on the README might be handy to get the tests passing with the postgres flag set to true.