Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postgres Tests #64

Merged
merged 6 commits into from
Nov 30, 2017
Merged

Postgres Tests #64

merged 6 commits into from
Nov 30, 2017

Conversation

illmade
Copy link

@illmade illmade commented Nov 30, 2017

github: FintanH and I thought some instructions on the README might be handy to get the tests passing with the postgres flag set to true.

README.md Outdated

### Tests and Postgres

To ```stack test``` with Postgresql you'll need to set the Postgres flag to true in esqueleto.cabal
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another way to do this: stack test --flag esqueleto:postgresql

README.md Outdated
Default: False
```

If you don't have Postgres install it. Using apt-get it's just:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add instructions for other users maybe? I'm thinking homebrew or else link to postgres site itself.

README.md Outdated
postgres=# \password esqutest
```

Now ```stack test``` should envoke and pass all the Postgres tests.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeat from comment above stack test --flag esqueleto:postgresql

@illmade
Copy link
Author

illmade commented Nov 30, 2017

Added homebrew instructions and command line flag instruction

Copy link
Collaborator

@FintanH FintanH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) @bitemyapp You happy with this?

@bitemyapp
Copy link
Owner

This is great, thank you! @illmade @FintanH is this good to go?

@FintanH FintanH merged commit 23466a9 into bitemyapp:master Nov 30, 2017
@FintanH
Copy link
Collaborator

FintanH commented Nov 30, 2017

Merged 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants