Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to WASM #55

Merged
merged 28 commits into from
Apr 15, 2021
Merged

Upgrade to WASM #55

merged 28 commits into from
Apr 15, 2021

Conversation

fanatid
Copy link
Member

@fanatid fanatid commented Apr 15, 2021

This is the same as #53 but without node bindings.

Previous work will be available in rust-bindings-api branch: https://github.com/bitcoinjs/tiny-secp256k1/tree/rust-bindings-napi

fanatid added 28 commits March 5, 2021 19:10
@fanatid
remove C++ addon
e957c7a
@fanatid
remove .npmignore
04d94c0
@fanatid
remove travis ci
bd9839b
@fanatid
add wasm
630282f
@fanatid
more const in rust
c5a426d
@fanatid
improve isPointCompressed
5206116
@fanatid
use fromHex/toHex in tests, Uint8Array instead Buffer
f1e86f8
@fanatid
Use patched secp256k1-sys
c372dac
@fanatid
Add test in browser env (#4)
f436690
@fanatid
Add Node.js addon (#5)
ef19e05
@fanatid
set custom stack size (#6)
8259e86
@fanatid
add benches (#7)
424ec64
@fanatid
More benches (#8)
b9a7b6d
@fanatid
remove extra await in benches
01dd17a
@fanatid
Add Dockerfile (#10)
0ed0bb2
@fanatid
Use TypeScript (#9)
3ee8dc7
@fanatid
Add examples (#11)
f63b100
@fanatid
Downgrade node version (#12)
e5cb60e
@fanatid
Add coverage (#13)
9ddd584
@fanatid
Add CI (#14)
e64f6dd
@fanatid
Merge signWithEntropy to sign (#15)
1c03ef9
@fanatid
use npm ci instead npm i
c8d77e3
@fanatid
Use es6 import only (#16)
87db15d
@fanatid
update browser-run
eb62ba5
@fanatid
publish example to gh-pages
b44801f
@fanatid
Copy rust-toolchain to package
f5179d0
@fanatid
Remove electron-stream patch (#17)
364b416
@fanatid
Remove secp256k1-node
88eb5f3
@fanatid fanatid requested a review from junderw April 15, 2021 10:59
@fanatid fanatid mentioned this pull request Apr 15, 2021
Closed
15 tasks
@junderw
Copy link
Member

junderw commented Apr 15, 2021

Verified the diff from the previous PR I reviewed:

364b416...88eb5f3

Looks good to me.

utACK 88eb5f3 (But it doesn't look like the changes will break anything since it's just moving stuff around.

junderw
junderw approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@junderw junderw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 88eb5f3

@junderw
Copy link
Member

junderw commented Apr 15, 2021

Looks like the tests didn't break!

@junderw
Copy link
Member

junderw commented Apr 15, 2021

Next steps:

  1. Update README to explain WASM requirements, how to use it properly, how to build it yourself, toolchain requirements etc.
  2. Once README is updated, add a commit changing package.json and package-lock.json version to 2.0.0 and tag it.

@junderw junderw merged commit 364d214 into bitcoinjs:master Apr 15, 2021
@fanatid fanatid deleted the to-wasm-update branch April 15, 2021 11:17
@fanatid fanatid mentioned this pull request Apr 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junderw junderw junderw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanatid @junderw