Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): support Testnet4 in valid networks #1805

Merged
merged 1 commit into from
Jan 24, 2025
Merged

feat(wallet): support Testnet4 in valid networks #1805

merged 1 commit into from
Jan 24, 2025
+22 −9

Conversation

ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Jan 20, 2025 •
edited
Loading

Adds support for Testnet4 in valid networks.

fixes #1429

Notes to the reviewers

The Testnet4 variant is included in keys::any_network and keys::test_networks. Tests are updated accordingly and a new assertion is added to test_descriptor_from_str_with_keys_network checking the result of into_wallet_descriptor when the specified network is Network::Testnet4.

Changelog notice

Added:

  • Wallet can now be constructed using Network::Testnet4

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory added the new feature New feature or request label Jan 20, 2025
@notmandatory
Copy link
Member

concept ACK, would be nice to get this one into bdk_wallet 1.1 release.

@ValuedMammal ValuedMammal marked this pull request as ready for review January 20, 2025 18:30
@ValuedMammal ValuedMammal added this to the 1.1.0 milestone Jan 20, 2025
oleonardolima
oleonardolima reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK c8161d7

@luisschwab
Copy link
Contributor

Concept ACK c8161d7

@oleonardolima
Copy link
Contributor

It can be handled on another PR, but it'd be good also to update both example_esplora and example_electrum to cover Testnet4.

@tvpeter
Copy link
Contributor

tvpeter commented Jan 23, 2025

LGTM tACK c8161d7

@ValuedMammal
Copy link
Contributor Author

Rebased

notmandatory
notmandatory approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c8e8a6a

@notmandatory notmandatory merged commit 6ac38c3 into bitcoindevkit:master Jan 24, 2025
23 checks passed
@ValuedMammal ValuedMammal deleted the feat/testnet4 branch February 3, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleonardolima oleonardolima oleonardolima left review comments

@notmandatory notmandatory notmandatory approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels
new feature New feature or request
Projects
BDK
Status: Done
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Add support for testnet4
5 participants
@ValuedMammal @notmandatory @luisschwab @oleonardolima @tvpeter