-
Notifications
You must be signed in to change notification settings - Fork 36.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: add a few performance-related notes #9787
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should definitely make it in for release time, if we can.
doc/release-notes.md
Outdated
improved, leading to much shorter sync and initial block download times. | ||
|
||
- The script signature cache has been reimplemented as a high-performance, | ||
low-overhead "cuckoo cache" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...", allowing for more signatures to be cached and cache lookups to be performed much faster."
be skipped for ancestors of known-good blocks, without changing the security | ||
model. See below for more details. | ||
- In some cases, compact blocks are now relayed before being fully validated as | ||
per BIP152. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...", often allowing relay to happen fully without waiting for block validation."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you're getting at here, sounds the same to me :)
Please suggest a complete alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm, nevermind, you're probably right.
Could mention #8610 as well?
|
doc/release-notes.md
Outdated
per BIP152. | ||
- P2P networking has been refactored with a focus on concurrency and | ||
throughput. Network operations are no longer bottlenecked by validation. As a | ||
result, block fetching is several times faster that previous releases in many |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...several times faster than previous...
5704b9e
to
1c194e0
Compare
Updated with the suggestions above, except for the one I'm unclear about. |
doc/release-notes.md
Outdated
Performance Improvements | ||
-------------- | ||
|
||
Validation speed and network propogation performance have been greatly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"propagation"
doc/release-notes.md
Outdated
-------------- | ||
|
||
Validation speed and network propogation performance have been greatly | ||
improved, leading to much shorter sync and initial block download times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps qualify this with "in some configurations"... people who are bandwidth starved or I/O bottlenecked won't need much difference.
1c194e0
to
95e68df
Compare
95e68df release: add a few performance-related notes (Cory Fields)
Tried to keep these simple and human-readable.
I'm sure I've left out a few, please chime in with any others.
Because these all depend on specific use-cases (number of cores, peers, bandwidth, etc), I've left out any specific performance figures. If preferred, we could instead list numbers plus reference system/scenario.