Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: add a few performance-related notes #9787

Merged
merged 1 commit into from
Feb 23, 2017

Conversation

theuni
Copy link
Member

@theuni theuni commented Feb 17, 2017

Tried to keep these simple and human-readable.

I'm sure I've left out a few, please chime in with any others.

Because these all depend on specific use-cases (number of cores, peers, bandwidth, etc), I've left out any specific performance figures. If preferred, we could instead list numbers plus reference system/scenario.

Copy link
Contributor

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely make it in for release time, if we can.

improved, leading to much shorter sync and initial block download times.

- The script signature cache has been reimplemented as a high-performance,
low-overhead "cuckoo cache"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...", allowing for more signatures to be cached and cache lookups to be performed much faster."

be skipped for ancestors of known-good blocks, without changing the security
model. See below for more details.
- In some cases, compact blocks are now relayed before being fully validated as
per BIP152.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...", often allowing relay to happen fully without waiting for block validation."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what you're getting at here, sounds the same to me :)
Please suggest a complete alternative.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, nevermind, you're probably right.

@maflcko
Copy link
Member

maflcko commented Feb 20, 2017 via email

per BIP152.
- P2P networking has been refactored with a focus on concurrency and
throughput. Network operations are no longer bottlenecked by validation. As a
result, block fetching is several times faster that previous releases in many
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...several times faster than previous...

@theuni theuni force-pushed the update-release-notes branch from 5704b9e to 1c194e0 Compare February 23, 2017 06:28
@theuni
Copy link
Member Author

theuni commented Feb 23, 2017

Updated with the suggestions above, except for the one I'm unclear about.

@theuni theuni changed the title [WIP] release: add a few performance-related notes release: add a few performance-related notes Feb 23, 2017
Performance Improvements
--------------

Validation speed and network propogation performance have been greatly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"propagation"

--------------

Validation speed and network propogation performance have been greatly
improved, leading to much shorter sync and initial block download times.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps qualify this with "in some configurations"... people who are bandwidth starved or I/O bottlenecked won't need much difference.

@theuni theuni force-pushed the update-release-notes branch from 1c194e0 to 95e68df Compare February 23, 2017 20:44

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@laanwj laanwj merged commit 95e68df into bitcoin:0.14 Feb 23, 2017
laanwj added a commit that referenced this pull request Feb 23, 2017
95e68df release: add a few performance-related notes (Cory Fields)
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants