Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-839): add requesterPaymail when adding contact #78

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

Description

  • Update spv-wallet-go-client. Add requester paymail when adding new contact

@pawellewandowski98 pawellewandowski98 self-assigned this Jun 24, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner June 24, 2024 08:27
Copy link
Contributor

github-actions bot commented Jun 24, 2024

Manual Tests

πŸ’š Manual testing by @chris-4chain resulted in success.

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@ac4ch ac4ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@chris-4chain chris-4chain added the tested PR was tested by a team member label Jun 25, 2024
@pawellewandowski98 pawellewandowski98 force-pushed the feat-839-add-requester-paymail-to-contacts branch from 17794ea to 8856d41 Compare June 25, 2024 13:58
@pawellewandowski98 pawellewandowski98 merged commit 84103b7 into main Jun 25, 2024
6 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feat-839-add-requester-paymail-to-contacts branch June 25, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants