Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BUX-250): fix decode;add spv and decode tests for corrupted/invalid beef #45

Merged
merged 5 commits into from
Nov 15, 2023
Merged

fix(BUX-250): fix decode;add spv and decode tests for corrupted/invalid beef #45

merged 5 commits into from
Nov 15, 2023

Conversation

arkadiuszos4chain
Copy link
Contributor

@arkadiuszos4chain arkadiuszos4chain commented Nov 14, 2023 •
edited
Loading

  • fix BEEF decode - return errors on invalid BEEF
  • add tests with invalid BEEFs
  • add tests for SPV with corrupted BEEFs

** set version to v0.7.2**

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@arkadiuszos4chain arkadiuszos4chain self-assigned this Nov 14, 2023
@arkadiuszos4chain arkadiuszos4chain changed the title Test 250 add spv beef tests fix(BUX-250): fix decode;add spv and decode tests for corrupted/invalid beef Nov 14, 2023
@arkadiuszos4chain arkadiuszos4chain marked this pull request as ready for review November 14, 2023 19:31
@arkadiuszos4chain arkadiuszos4chain requested a review from a team as a code owner November 14, 2023 19:34
pawellewandowski98
pawellewandowski98 reviewed Nov 15, 2023
View reviewed changes
p2p_beef_tx.go Outdated Show resolved Hide resolved
wregulski
wregulski requested changes Nov 15, 2023
View reviewed changes
p2p_beef_tx.go Show resolved Hide resolved
@arkadiuszos4chain arkadiuszos4chain merged commit 6fb0fc9 into main Nov 15, 2023
2 checks passed
@arkadiuszos4chain arkadiuszos4chain deleted the test-250-add-spv-beef-tests branch November 15, 2023 12:30
@bsvassociation-bot bsvassociation-bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wregulski wregulski wregulski approved these changes

@pawellewandowski98 pawellewandowski98 pawellewandowski98 approved these changes

Assignees

@arkadiuszos4chain arkadiuszos4chain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkadiuszos4chain @pawellewandowski98 @wregulski