Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests don't work with NDEBUG. #6

Closed
gmaxwell opened this issue Mar 31, 2014 · 0 comments · Fixed by #31
Closed

Tests don't work with NDEBUG. #6

gmaxwell opened this issue Mar 31, 2014 · 0 comments · Fixed by #31
Labels
bug

Comments

@gmaxwell
Copy link
Contributor

The tests are burring some of actual test inside an ordinary assert macro. The tests shouldn't silently get eliminated when the compile options change.

Things that we don't want get getting removed when compiled with NDEBUG should have a library specific assert function or the like.
@sipa sipa mentioned this issue Jun 15, 2014
Merged
@sipa sipa added the bug label Jun 15, 2014
@sipa sipa closed this as completed in #31 Jun 20, 2014
@subtly subtly mentioned this issue Aug 13, 2014
Closed
nkohen added a commit to nkohen/secp256k1 that referenced this issue Apr 14, 2020
@nkohen
Merge pull request bitcoin-core#6 from nkohen/revert-java-test
84ef92d 
Removed check-java from tests
nkohen added a commit to nkohen/secp256k1 that referenced this issue Apr 16, 2020
@nkohen
Merge pull request bitcoin-core#6 from nkohen/revert-java-test
e023925 
Removed check-java from tests
real-or-random added a commit that referenced this issue Oct 29, 2024
@real-or-random
Merge #1582: cmake, test: Add secp256k1_ prefix to test names
9a8db52 
87384f5 cmake, test: Add `secp256k1_` prefix to test names (Hennadii Stepanov)

Pull request description:

  This PR improves regex matching options when using `ctest` in downstream projects, such as Bitcoin Core.

  For instance, a downstream project users can filter their tests like that:
  ```
  ctest --tests-regex "secp256k1"
  ```
  or
  ```
  ctest --exclude-regex "secp256k1"
  ```

  A `ctest` log with this PR:
  ```
  $ ctest --test-dir build -j 16
  Internal ctest changing into directory: /home/hebasto/git/secp256k1/secp256k1/build
  Test project /home/hebasto/git/secp256k1/secp256k1/build
      Start 1: secp256k1_noverify_tests
      Start 2: secp256k1_tests
      Start 3: secp256k1_exhaustive_tests
      Start 4: secp256k1_ecdsa_example
      Start 5: secp256k1_ecdh_example
      Start 6: secp256k1_schnorr_example
      Start 7: secp256k1_ellswift_example
      Start 8: secp256k1_musig_example
  1/8 Test #4: secp256k1_ecdsa_example ..........   Passed    0.00 sec
  2/8 Test #5: secp256k1_ecdh_example ...........   Passed    0.00 sec
  3/8 Test #6: secp256k1_schnorr_example ........   Passed    0.00 sec
  4/8 Test #7: secp256k1_ellswift_example .......   Passed    0.00 sec
  5/8 Test #8: secp256k1_musig_example ..........   Passed    0.00 sec
  6/8 Test #3: secp256k1_exhaustive_tests .......   Passed    6.19 sec
  7/8 Test #1: secp256k1_noverify_tests .........   Passed   38.83 sec
  8/8 Test #2: secp256k1_tests ..................   Passed   91.66 sec

  100% tests passed, 0 tests failed out of 8

  Total Test time (real) =  91.67 sec
  ```

ACKs for top commit:
  theuni:
    utACK 87384f5
  real-or-random:
    utACK 87384f5

Tree-SHA512: d8e46558cf58c9c660544b7bdfed24c991eb3e120b6511aa3968f509190130e498749a3c4dbabc87a7f22f0aa0056c6bcd3fc6c44f5eb131588945d593546840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce CHECK() for tests that works with NDEBUG. sipa/secp256k1
2 participants
@sipa @gmaxwell