[PoC] [do not merge]: Support runtime appearance adjustment on macOS #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is a prerequisite to support changeable appearance on macOS.
This change fixes the GUI when changing appearance on macOS.
jarolrod
reviewed
Apr 8, 2021
There was a problem hiding this comment.
Concept ACK,
This seems to be a step in the right direction to supporting theme switching on macOS. The icons this PR touches do get recolorized.
Below are some screenshots with all possible build options on macOS 11.2.3 and macOS 10.15.7, comparing master and pr.
It is weird that dark mode does not work at all on a native depends build, but works on a cross-compile depends build.
Master
Compiled Natively
macOS 11.2.3
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
macOS 10.15.7
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
Depends Build Natively
macOS 11.2.3
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
macOS 10.15.7
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
Depends Cross Compile (from Linux)
macOS 11.2.3
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
macOS 10.15.7
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
PR 0993439
Compiled Natively
macOS 11.2.3
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
macOS 10.15.7
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
Depends Build Natively
macOS 11.2.3
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
macOS 10.15.7
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
Depends Cross Compile (from Linux)
macOS 11.2.3
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
macOS 10.15.7
| Start: Light Mode | Switch to Dark Mode |
|---|---|
 |
 |
|
Closed in favor of the complete solution #275. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only toolbar icons support Dark/Light runtime switching for now.