refactor: Use template function qOverload in signal-slot connections #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does not change behavior.
hebasto
force-pushed
the
210323-overload
branch
from
c8169f4 to
cdbc2bd
Compare
That is not the case now since bitcoin/bitcoin#21811 is merged. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 11, 2021
gwillen
pushed a commit
to ElementsProject/elements
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nice template function
qOverloadis available for us now (bitcoin/bitcoin#20413, bitcoin/bitcoin#21286).Its usage makes code much more readable.
This PR does not change behavior.