Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: Remove unused AskPassphraseDialog::Decrypt #109

Merged
merged 3 commits into from
Nov 18, 2020

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Oct 23, 2020

Grabbed from #42 with an additional commit.

Fix #1.

@promag
Copy link
Contributor

promag commented Oct 26, 2020

Concept ACK.

Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK f886a20.

@maflcko
Copy link
Contributor

maflcko commented Oct 28, 2020

Please remove bool encrypted as well

@hebasto
Copy link
Member Author

hebasto commented Oct 28, 2020

Updated f886a20 -> 4146a31 (pr109.01 -> pr109.02, diff):

Please remove bool encrypted as well

@maflcko
Copy link
Contributor

maflcko commented Oct 28, 2020

ACK 4146a31

Copy link
Contributor

@promag promag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 4146a31.

@jonasschnelli jonasschnelli added this to the 0.22.0 milestone Nov 11, 2020
@maflcko maflcko merged commit 54532f4 into bitcoin-core:master Nov 18, 2020
@hebasto hebasto deleted the 201023-decrypt branch November 18, 2020 10:46
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 18, 2020
…::Decrypt

4146a31 qt, wallet: Drop unused parameter in WalletModel::setWalletEncrypted (Hennadii Stepanov)
f886a20 qt, wallet: Drop unused parameter in Wallet{Frame|View}::encryptWallet (Hennadii Stepanov)
6e95011 qt, wallet: Remove unused AskPassphraseDialog::Decrypt (Hennadii Stepanov)

Pull request description:

  Grabbed from #42 with an additional commit.

  Fix #1.

ACKs for top commit:
  MarcoFalke:
    ACK 4146a31
  promag:
    Code review ACK 4146a31.

Tree-SHA512: 6070d8995525af826ad972cf1b8988ff98af0528eef285a07ec7ba0e2e92a7a6173a19dc371de94d4b437fa10f7921166e45a081de6ed2f4306e6502aafc94ee
apoelstra added a commit to apoelstra/elements that referenced this pull request Dec 3, 2020
gwillen pushed a commit to ElementsProject/elements that referenced this pull request Mar 23, 2021
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Dec 23, 2021
Summary:
Co-authored-by: Sehyun Chung <sehyun@berkeley.edu>

This is a backport of [[bitcoin-core/gui#109 | core-gui#109]] [1/3]
bitcoin-core/gui@6e95011

Test Plan: `ninja all check-all`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10737
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Dec 23, 2021
Summary:
This is a backport of [[bitcoin-core/gui#109 | core-gui#109]] [2/3]
bitcoin-core/gui@f886a20

Test Plan: `ninja all check-all`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10738
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Dec 23, 2021
Summary:
This is a backport of [[bitcoin-core/gui#109 | core-gui#109]] [3/3]
bitcoin-core/gui@4146a31

Test Plan: `ninja all check-all`

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10739
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gui: Remove unused Decrypt wallet
4 participants