Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

Binary support for ebd-all-minilm #98

Closed
wants to merge 21 commits into from

Conversation

nsosio
Copy link
Contributor

@nsosio nsosio commented Nov 3, 2023

Fixes #97

@nsosio
Copy link
Contributor Author

nsosio commented Nov 3, 2023

\cc @casperdcl @tiero

@nsosio nsosio changed the base branch from dev to v1 November 3, 2023 12:13
@casperdcl
Copy link
Contributor

casperdcl commented Nov 3, 2023

embeddings-all-minilm-l6-v2-binary/manifest.json Outdated Show resolved Hide resolved
embeddings-all-minilm-l6-v2-binary/manifest.json Outdated Show resolved Hide resolved
embeddings-all-minilm-l6-v2-binary/manifest.json Outdated Show resolved Hide resolved
@nsosio nsosio marked this pull request as ready for review November 3, 2023 13:27
@casperdcl
Copy link
Contributor

this PR probably needs rebasing :)

@nsosio
Copy link
Contributor Author

nsosio commented Nov 3, 2023

What should be the path used in the model path where the files from HF are downloaded? The service expects --model-path to be the path to the folder containing all the files

@casperdcl
Copy link
Contributor

casperdcl commented Nov 3, 2023

--model-path . (i.e. curdir) I think (based on https://github.com/premAI-io/prem-app/blob/main/src-tauri/src/controller_binaries.rs)

@nsosio
Copy link
Contributor Author

nsosio commented Nov 4, 2023

@casperdcl added --model-dir .

@casperdcl
Copy link
Contributor

merged & released updated binary in services :)

@tiero tiero closed this Nov 7, 2023
@nsosio nsosio deleted the feat/binary-ebd-all-minilm branch December 3, 2023 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sentence transformer binary
5 participants