use zip for image download as default #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NFiedler
previously requested changes
Dec 12, 2020
|
The script currently does not check if an imageset has a zip already. There should be some error handling for that case, e.g. a warning that either the imageset or zip does not exist. Additionally it should be possible to use the old method by using a command line argument. |
|
I added error handling, but was not able to test it for a non existing zip file, because I currently do not have an development environment of the ImageTagger. |
|
I tested the script for non-existing zip files and fixed a few minor things. Looks good now. |
timonegk
approved these changes
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the images are downloaded individually by default. This is slow.
This pull request replaces this behavior by downloading the zip file for the imageset instead. This works significantly faster (in my experiments).
Currently the other method for downloading is still included in the download script, in case the zip download does not work. This way it is just a single line to replace to go back to the previous behavior.
Closes #159