Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protobuf aarch64 binaries for ARM processors #955

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

namloan
Copy link
Contributor

@namloan namloan commented Jul 2, 2023

aarch64 binaries have been available since version 3.5.0, therefore it shouldn't be needed to default to x86_64.

I could successfully run the app in an Apple M2 Pro. Would be great if someone with M1 could test and verify.

@alvasw
Copy link
Contributor

alvasw commented Jul 2, 2023

Hi @namloan!
We need to switch to the Tor (and potentially Electrum) too. Otherwise Bisq 2 cannot connect to other nodes.

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw
Copy link
Contributor

alvasw commented Jul 4, 2023

@namloan Please sign your commits with your GPG key. For further details see: https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md#sign-your-commits-with-gpg

@namloan
Copy link
Contributor Author

namloan commented Jul 4, 2023

@alvasw sure, will sign the commit.

Based on your comment I was under the impression that it was absolutely needed to also make the swtich in the Tor and Electrum binaries or otherwise this change would break those integrations. Did I misunderstand? I only tested this on clearnet.

aarch64 binaries have been available since version 3.5.0, therefore
it shouldn't be needed to default to x86_64.
@alvasw
Copy link
Contributor

alvasw commented Jul 5, 2023

Based on your comment I was under the impression that it was absolutely needed to also make the swtich in the Tor and Electrum binaries or otherwise this change would break those integrations. Did I misunderstand? I only tested this on clearnet.

Your PR only uses the aarch64 Protobuf compiler, so the build should be faster on M1s/M2s. The compiled output is still not aarch64. To support M1s/M2s natively, we need to update the Tor and Electrum binaries, and tell jpackage to create a aarch64 package.

@alvasw alvasw merged commit d276463 into bisq-network:main Jul 5, 2023
3 checks passed
@namloan namloan deleted the aarch64_protobuf branch July 7, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants