Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pix and Faster Payments payment methods #1115

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Add Pix and Faster Payments payment methods #1115

merged 2 commits into from
Aug 11, 2023

Conversation

namloan
Copy link
Contributor

@namloan namloan commented Aug 9, 2023

HenrikJannsen
HenrikJannsen approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

alvasw
alvasw approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw
Copy link
Contributor

alvasw commented Aug 10, 2023

I can't merge this PR due to a merge conflig in account/src/main/proto/account.proto.

HenrikJannsen
HenrikJannsen approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

alvasw
alvasw approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alvasw alvasw merged commit f4d2f46 into bisq-network:main Aug 11, 2023
3 checks passed
@namloan namloan deleted the pix_faster_payments branch August 11, 2023 13:36
@namloan namloan mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvasw alvasw alvasw approved these changes

@HenrikJannsen HenrikJannsen HenrikJannsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@namloan @alvasw @HenrikJannsen