Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL was broken with the /bisq path and just redirecting to mempool front page #7246

Merged

Conversation

cparke2
Copy link
Contributor

@cparke2 cparke2 commented Sep 15, 2024

Simple 1-line URL fix for the BsqBlockChainExplorer links.

Copy link

boring-cyborg bot commented Sep 15, 2024

Thanks for opening this pull request!

Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.

A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.

@cparke2 cparke2 force-pushed the fix-bsq-block-explorer-url branch 3 times, most recently from f192d2d to e825817 Compare September 17, 2024 01:16
The fix is to simply not use /bisq in the URL.
@cparke2
Copy link
Contributor Author

cparke2 commented Sep 17, 2024

Force pushes were to GPG sign the commit and improve the commit message, no code changes.

Copy link
Collaborator

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@HenrikJannsen HenrikJannsen merged commit 74bec53 into bisq-network:master Sep 17, 2024
Copy link

boring-cyborg bot commented Sep 17, 2024

Awesome work, congrats on your first merged pull request!

@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.18 milestone Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants