Add API for payment started with XMR auto conf params #7036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
closed this
ghost
reopened this
|
It works great, thank you! |
alvasw
suggested changes
Feb 25, 2024
ghost
closed this
|
@jmacxx are we not going to have this change implemented? |
|
I had to fix merge conflicts with the current master branch. Also, I don't know how to implement @alvasw suggestion above. |
ghost
reopened this
|
From what I can see, you have implemented @alvasw, for consistency sake would it make more sense to change these checks based on your suggestions separately, when it's done for all parameters? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7033
Basedon / follow-on from #7023.
Allows
tx-id&tx-keyto be specified for XMR auto-confirm.