Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give more time before activating BM capping algo change #6989

Merged
merged 1 commit into from Jan 8, 2024
Merged

Give more time before activating BM capping algo change #6989

merged 1 commit into from Jan 8, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 2, 2024

Related to #6949. bisq-network/proposals/issues/412

All bisq clients must be upgraded before the activation date.

If one partner to a trade is running a prior release, trade will fail due to the delayed payout transaction not matching.

Change burning man algorithm activation date Jan 1 2024 -> Feb 1 2024.

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 172628f into bisq-network:master Jan 8, 2024
3 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.15 milestone Jan 8, 2024
@ghost
Copy link
Author

ghost commented Mar 20, 2024

The Bisq1 1.9.15 release has been delayed longer than anyone anticipated. I (and presumably @stejbac) thought it would happen Dec 2023. It did not, and this PR was created to extend the proposal 412 activation date into the future. March 2024 we're still waiting for release, and the prop 412 activation date needs to be pushed forward again into the future. I raised this point to the maintainers but it has not been addressed.

Leaving the feature activated by default puts users who build from source at risk of failed trades.

I will create another PR to push the activation date forward another two months.

@alejandrogarcia83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant