Detect and handle corrupted SPV state allowing user-initiated resync. #6961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6714, resolves #6844, resolves #6371, resolves #5050
PRE:
Corrupted SPV resulted in the following message, user can do nothing / the app will not start. User would have to manually delete
bisq.spvchain. In-progress trades can be thrown into an error state such as "NullPointerError" & "Locked up funds from failed trade".POST:
Corrupted SPV will result in a message that has an option to initiate an SPV resync from the app. This is safer because a semaphore protects the state of Bisq trades.