Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tx validation requests when the DAO state is ready. #6810

Merged
merged 1 commit into from Aug 15, 2023
Merged

Allow Tx validation requests when the DAO state is ready. #6810

merged 1 commit into from Aug 15, 2023

Conversation

ghost
Copy link

@ghost ghost commented Aug 15, 2023

A bug was raised whereby sometimes at startup, offers were being disabled.

It happens if the offer validation is sooner than the DAO being ready, in which case the valid BM fee receiver addresses are not known.


TriggerPriceService validates open offers at startup, by testing mempoolService.canRequestBeMade() and if so, mempoolService.validateOfferMakerTx(). Now, canRequestBeMade() will check the DAO state, and if not ready the checking will be postponed.

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Good catch!! :-)

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit bbaf3dc into bisq-network:master Aug 15, 2023
12 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.13 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants