Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing TakeBuyBTCOfferTest #6732

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Fix failing TakeBuyBTCOfferTest #6732

merged 1 commit into from
Jul 6, 2023

Conversation

alyokaz
Copy link
Contributor

@alyokaz alyokaz commented Jun 14, 2023 •
edited
Loading

The TakeBuyBTCOfferTest was failing as amount and minAmount were set above the maximum trade limit for a new user which is 0.1 BTC.

This change sets amount and minAmount of the offer to 10_000_000, the max trade limit.

@alyokaz alyokaz force-pushed the fix-failing-takebuybtcoffertest branch from 2666b9f to d30af40 Compare June 14, 2023 14:28
alvasw
alvasw approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

alejandrogarcia83
alejandrogarcia83 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83
Copy link
Contributor

Hi @AllyKaz!
We only accept signed commits in Bisq. Please sign your commits with you PGP key and re-upload them.
For further details see: https://github.com/bisq-network/bisq/blob/master/CONTRIBUTING.md#sign-your-commits-with-gpg

@alvasw alvasw mentioned this pull request Jul 1, 2023
Merged
@alyokaz
Fix failing TakeBuyBTCOfferTest
d2f9172 
Fix failing test by setting amount and minAmount to the maxTradeLimit for
fiat accounts (0.1 BTC)
@alyokaz alyokaz force-pushed the fix-failing-takebuybtcoffertest branch from d30af40 to d2f9172 Compare July 4, 2023 20:12
@alyokaz
Copy link
Contributor Author

alyokaz commented Jul 4, 2023

Commit signed as requested.

@alejandrogarcia83 alejandrogarcia83 merged commit ff44e18 into bisq-network:master Jul 6, 2023
13 checks passed
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.13 milestone Jul 6, 2023
@alvasw alvasw mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvasw alvasw alvasw approved these changes

@alejandrogarcia83 alejandrogarcia83 alejandrogarcia83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.14
Development

Successfully merging this pull request may close these issues.
3 participants
@alyokaz @alejandrogarcia83 @alvasw