Fix bisq.properties pickup in ApiTest #6724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyokaz
force-pushed
the
fix-bisq-properties-pickup
branch
from
88efeff
to
5b0c5d5
Compare
alvasw
suggested changes
Jun 14, 2023
There was a problem hiding this comment.
Do we need to delete the bisq.properties file in the root directory? The deletion breaks the Gradle Build Cache. It's smarter to include/exclude the file explicitly [1], or even have them multiple times (for all instances) in the resources directory.
I know that you didn't write the initial file-deletion code.
[1] https://docs.gradle.org/current/dsl/org.gradle.language.jvm.tasks.ProcessResources.html
alyokaz
force-pushed
the
fix-bisq-properties-pickup
branch
2 times, most recently
from
b73a03e
to
2d65ca3
Compare
Copy 'bisq.properties' file in apitest/src/main/resources to each instance's DataDir on startup to allow pickup by the instance.
Remove redundant directory moving and renaming. Make buildResourcesDir property less brittle.
Stop the deletion of the original bisq.properties file after it's copied into the instances data directories.
alyokaz
force-pushed
the
fix-bisq-properties-pickup
branch
from
2d65ca3
to
1a931b8
Compare
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change copies the 'bisq.properties' file in apitest/src/main/resources to each instance's DataDir on test harness startup.
This was necessary as #5718 was not copying the file into the instance's data dir but leaving it in 'build/resources/main' where it wasn't picked up by the instance.