Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BM receive address selection #6700

Conversation

HenrikJannsen
Copy link
Collaborator

Fixes #6699

We still keep the parameter as it will be reused later for the new bugfix

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
…DATE,

isHotfixActivated to isBugfix6699Activated,
wasHotfixActivatedAtTradeDate to wasBugfix6699ActivatedAtTradeDate

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
…when we use the custom address and when the change address.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Implement new selection algorithm.
Add methods for accessing the receiverAddress (not used yet, but will be used in next commits)

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
…n to make sure the old field is not used anymore from any client.

Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
Signed-off-by: HenrikJannsen <boilingfrog@gmx.com>
@HenrikJannsen HenrikJannsen changed the title Fix bm receive address selection Fix BM receive address selection May 17, 2023
Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit 1fa637c into bisq-network:master May 23, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.11 milestone May 23, 2023
@HenrikJannsen HenrikJannsen deleted the fix-bm-receive-address-selection branch May 26, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with selecting the distributed BM receiver address
3 participants