Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit offer min/max amount deviation to 50%. #6593

Merged
merged 1 commit into from Mar 11, 2023
Merged

Limit offer min/max amount deviation to 50%. #6593

merged 1 commit into from Mar 11, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 28, 2023

Requested by @refund-agent2 in bisq-network/projects#67

  • At offer entry, limit the potential difference between min/max BTC amounts.
  • Avoids cases where the security deposit is the majority loss in arbitration due to a tiny trade amount taken.

minAmountWarning

@refund-agent2 refund-agent2 mentioned this pull request Feb 28, 2023
Open
4 tasks
HenrikJannsen
HenrikJannsen approved these changes Mar 11, 2023
View reviewed changes
Copy link
Collaborator

@HenrikJannsen HenrikJannsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

alejandrogarcia83
alejandrogarcia83 approved these changes Mar 11, 2023
View reviewed changes
Copy link
Contributor

@alejandrogarcia83 alejandrogarcia83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alejandrogarcia83 alejandrogarcia83 merged commit b88cd58 into bisq-network:master Mar 11, 2023
@alejandrogarcia83 alejandrogarcia83 added this to the v1.9.10 milestone Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9.10
Development

Successfully merging this pull request may close these issues.
2 participants
@HenrikJannsen @alejandrogarcia83