Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target BitcoinJ version with "Reduce log level of two messages" patch #6497

Conversation

alejandrogarcia83
Copy link
Contributor

This change targets BitcoinJ with the following commit included bisq-network/bitcoinj#39.

@ghost
Copy link

ghost commented Jan 4, 2023

I applied this patch but am not sure how to verify which BitcoinJ is in the build.
The version shown is the same as before. BitcoinJ version 0.15.10.bisq.15 and hash of BitcoinJ commit 2a80db4
To see if the logging has improved I can run bisq for an extended period, but it is not easy to prove as the problem is intermittent and happens randomly to users.

PRE:

Dec-26 23:10:26.632 [JavaFX Application Thread] INFO  b.c.a.WalletAppSetup: Initialize WalletAppSetup with BitcoinJ version 0.15.10.bisq.15 and hash of BitcoinJ commit 2a80db4 
Dec-26 23:10:26.647 [JavaFX Application Thread] INFO  b.c.b.s.WalletsSetup: Socks5Proxy for bitcoinj: socks5Proxy=null 
Dec-26 23:10:26.661 [JavaFX Application Thread] INFO  o.b.c.Context: Creating bitcoinj 0.15.10.bisq.15 context. 

POST:

Jan-03 20:00:58.780 [JavaFX Application Thread] INFO  b.c.a.WalletAppSetup: Initialize WalletAppSetup with BitcoinJ version 0.15.10.bisq.15 and hash of BitcoinJ commit 2a80db4 
Jan-03 20:00:58.799 [JavaFX Application Thread] INFO  b.c.b.s.WalletsSetup: Socks5Proxy for bitcoinj: socks5Proxy=localhost:46779	Version 5 
Jan-03 20:00:58.804 [JavaFX Application Thread] INFO  o.b.c.Context: Creating bitcoinj 0.15.10.bisq.15 context. 

ghost
ghost previously approved these changes Jan 4, 2023
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK based on #6497 (comment)

@alejandrogarcia83
Copy link
Contributor Author

I'll update the version number and create new bitcoinj release. I don't have the necessary permissions. Waiting for @gabernard to add me.

@alejandrogarcia83
Copy link
Contributor Author

@jmacxx I updated the version number.

Copy link
Contributor

@alvasw alvasw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Jan-16 17:57:01.049 [JavaFX Application Thread] INFO  bisq.core.app.BisqSetup: Init wallet 
Jan-16 17:57:01.050 [JavaFX Application Thread] INFO  bisq.core.app.WalletAppSetup: Initialize WalletAppSetup with BitcoinJ version 0.15.10.bisq.16 and hash of BitcoinJ commit 2a80db4 
Jan-16 17:57:01.060 [JavaFX Application Thread] INFO  b.core.btc.setup.WalletsSetup: Socks5Proxy for bitcoinj: socks5Proxy=localhost:37867	Version 5 
Jan-16 17:57:01.062 [JavaFX Application Thread] INFO  org.bitcoinj.core.Context: Creating bitcoinj 0.15.10.bisq.16 context. 

Copy link
Contributor

@gabernard gabernard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gabernard gabernard merged commit 10dd102 into bisq-network:master Jan 17, 2023
@alejandrogarcia83 alejandrogarcia83 deleted the target_reduce_log_level_bitcoinj branch January 17, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants